Søren Eggert Lundsteen Olsen
2284e7f082
A DBA should be able to review every statement SQLInsight sends to a monitored server before granting it access. "SQL Scripts/<rule-id>.sql" holds, per rule (82 built-in, 16 community), a Danish header (what and why, how C# judges the data, thresholds with config keys, severity, exact GRANTs, versions, collector file and member) and the collector's SQL verbatim, every version variant as its own batch. "_collectors/<Collector>.sql" holds each collector's queries once. The only statement that is not strictly read-only is documented in the scripts: the deadlock collector's session temp table (#system_health). Inline SQL in the collectors moved to internal constants and Build*Sql methods (no text changed), so SqlScriptTests can check that the scripts still contain the SQL the code sends, that every rule has a script, that every collector query is registered, and that nothing writes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
89 lines
5.3 KiB
Transact-SQL
89 lines
5.3 KiB
Transact-SQL
-- ===================================================================================================================
|
|
-- SQLI-CFG-005: Plan cache er fyldt med engangsplaner
|
|
-- ===================================================================================================================
|
|
-- Regel-id: SQLI-CFG-005
|
|
-- Titel: Plan cache er fyldt med engangsplaner
|
|
-- Alvor: Low
|
|
-- Versioner: SQL Server 2005 og nyere (DynamicManagementViews; indstillingen findes fra 2008 - mangler den, er
|
|
-- reglen "ikke målbar").
|
|
--
|
|
-- Hvad tjekkes, og hvorfor:
|
|
-- Om plan cache er fyldt med ad hoc-planer, der kun er brugt én gang, mens 'optimize for ad hoc workloads' er slået
|
|
-- fra.
|
|
--
|
|
-- Vurdering (sker i C# ud fra de indsamlede data, ikke i SQL'en, medmindre andet er nævnt):
|
|
-- Fund hvis 'optimize for ad hoc workloads' value_in_use = 0, og engangs-ad hoc-planer (objtype = Adhoc og
|
|
-- usecounts = 1) fylder mindst 25 % af plan cache og mindst 100 MB.
|
|
--
|
|
-- Grænseværdier (konfigurationsnøgle i agentens appsettings.json og standardværdi):
|
|
-- Andel >= 25 % og >= 100 MB (fast i koden).
|
|
--
|
|
-- Rettigheder til agentens login (se db/permissions/grant-least-privilege.sql; [agent] = agentens login):
|
|
-- GRANT VIEW SERVER STATE TO [agent]; -- SQL Server 2005-2019
|
|
-- GRANT VIEW SERVER PERFORMANCE STATE TO [agent]; -- SQL Server 2022+ (erstatter VIEW SERVER STATE)
|
|
-- GRANT VIEW SERVER SECURITY STATE TO [agent]; -- SQL Server 2022+
|
|
--
|
|
-- Data kommer fra (collector, fil : medlemmer, interval):
|
|
-- ConfigurationCollector
|
|
-- Fil: src/SQLInsight.Collectors/Instance/ConfigurationCollector.cs
|
|
-- Medlemmer: ConfigurationCollector.Sql2005, ConfigurationCollector.Sql2000
|
|
-- Interval: 15 min som standard (SQLInsight:CollectorIntervals:configuration)
|
|
-- Delt script: SQL Scripts/_collectors/ConfigurationCollector.sql
|
|
-- PlanCacheCollector
|
|
-- Fil: src/SQLInsight.Collectors/Instance/PlanCacheCollector.cs
|
|
-- Medlemmer: PlanCacheCollector.Sql
|
|
-- Interval: 15 min som standard (SQLInsight:CollectorIntervals:plan-cache)
|
|
-- Delt script: SQL Scripts/_collectors/PlanCacheCollector.sql
|
|
-- Regelkode: src/SQLInsight.Rules/Configuration/ConfigurationRules.cs : OptimizeForAdHocRule.Evaluate
|
|
--
|
|
-- Read-only: Ja: kun SELECT samt SET-sessionsindstillinger. Intet ændrer data, indstillinger eller objekter.
|
|
-- Kørsel: Kør i SSMS som agentens login (eller et login med samme rettigheder). Hver variant er sin egen batch
|
|
-- (GO); en variant for en anden SQL Server-version end din kan fejle - det er forventet.
|
|
-- Per-database-forespørgsler er vist for databasen msdb, som findes overalt: ret navnet til den
|
|
-- database, du vil se.
|
|
-- ===================================================================================================================
|
|
|
|
-- -------------------------------------------------------------------------------------------------------------------
|
|
-- Forbindelsen: Sessionsindstillinger, agenten sætter på hver forbindelse
|
|
-- -------------------------------------------------------------------------------------------------------------------
|
|
|
|
-- Variant: Alle versioner: sættes på hver forbindelse, agenten åbner
|
|
-- Kilde: SqlConnectionFactory.SessionSettings
|
|
-- Kode: src/SQLInsight.Connectivity/SqlConnectionFactory.cs : SqlConnectionFactory.SessionSettings
|
|
SET LOCK_TIMEOUT 5000; SET DEADLOCK_PRIORITY LOW; SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
|
|
GO
|
|
|
|
-- -------------------------------------------------------------------------------------------------------------------
|
|
-- ConfigurationCollector: sp_configure: konfigureret værdi og værdi i brug for alle serverindstillinger.
|
|
-- -------------------------------------------------------------------------------------------------------------------
|
|
|
|
-- Variant: SQL Server 2005 og nyere
|
|
-- Kilde: ConfigurationCollector.Sql2005
|
|
-- Kode: src/SQLInsight.Collectors/Instance/ConfigurationCollector.cs : ConfigurationCollector.Sql2005
|
|
SELECT name, CAST(value AS bigint), CAST(value_in_use AS bigint) FROM sys.configurations
|
|
GO
|
|
|
|
-- Variant: SQL Server 2000 (legacy ODBC-sti)
|
|
-- Kilde: ConfigurationCollector.Sql2000
|
|
-- Kode: src/SQLInsight.Collectors/Instance/ConfigurationCollector.cs : ConfigurationCollector.Sql2000
|
|
SELECT v.name, CAST(c.value AS bigint), CAST(r.value AS bigint)
|
|
FROM master.dbo.spt_values v
|
|
JOIN master.dbo.sysconfigures c ON c.config = v.number
|
|
JOIN master.dbo.syscurconfigs r ON r.config = v.number
|
|
WHERE v.type = 'C'
|
|
GO
|
|
|
|
-- -------------------------------------------------------------------------------------------------------------------
|
|
-- PlanCacheCollector: Plan cache: antal og størrelse af planer og af ad hoc-planer brugt én gang.
|
|
-- -------------------------------------------------------------------------------------------------------------------
|
|
|
|
-- Variant: SQL Server 2005 og nyere
|
|
-- Kilde: PlanCacheCollector.Sql
|
|
-- Kode: src/SQLInsight.Collectors/Instance/PlanCacheCollector.cs : PlanCacheCollector.Sql
|
|
SELECT
|
|
COUNT_BIG(*),
|
|
ISNULL(SUM(CAST(size_in_bytes AS bigint)), 0) / 1048576.0,
|
|
ISNULL(SUM(CASE WHEN objtype = N'Adhoc' AND usecounts = 1 THEN 1 ELSE 0 END), 0),
|
|
ISNULL(SUM(CASE WHEN objtype = N'Adhoc' AND usecounts = 1 THEN CAST(size_in_bytes AS bigint) ELSE 0 END), 0) / 1048576.0
|
|
FROM sys.dm_exec_cached_plans
|
|
GO
|