Søren Eggert Lundsteen Olsen
2284e7f082
A DBA should be able to review every statement SQLInsight sends to a monitored server before granting it access. "SQL Scripts/<rule-id>.sql" holds, per rule (82 built-in, 16 community), a Danish header (what and why, how C# judges the data, thresholds with config keys, severity, exact GRANTs, versions, collector file and member) and the collector's SQL verbatim, every version variant as its own batch. "_collectors/<Collector>.sql" holds each collector's queries once. The only statement that is not strictly read-only is documented in the scripts: the deadlock collector's session temp table (#system_health). Inline SQL in the collectors moved to internal constants and Build*Sql methods (no text changed), so SqlScriptTests can check that the scripts still contain the SQL the code sends, that every rule has a script, that every collector query is registered, and that nothing writes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
101 lines
6.1 KiB
Transact-SQL
101 lines
6.1 KiB
Transact-SQL
-- ===================================================================================================================
|
|
-- SQLI-JOB-002: SQL Server Agent kører ikke
|
|
-- ===================================================================================================================
|
|
-- Regel-id: SQLI-JOB-002
|
|
-- Titel: SQL Server Agent kører ikke
|
|
-- Alvor: High når der er aktive jobs; ellers Low.
|
|
-- Versioner: SQL Server 2005 og nyere. Bestået på Express (EngineEdition fra InstanceProbe), som ikke har SQL
|
|
-- Server Agent.
|
|
--
|
|
-- Hvad tjekkes, og hvorfor:
|
|
-- Om SQL Server Agent ikke kører, så ingen planlagte jobs (backups!) bliver udført.
|
|
--
|
|
-- Vurdering (sker i C# ud fra de indsamlede data, ikke i SQL'en, medmindre andet er nævnt):
|
|
-- Agenten regnes som kørende, hvis der findes mindst én session med program_name LIKE 'SQLAgent - %'. Fund hvis
|
|
-- ingen findes, og udgaven ikke er Express.
|
|
--
|
|
-- Grænseværdier (konfigurationsnøgle i agentens appsettings.json og standardværdi):
|
|
-- Ingen.
|
|
--
|
|
-- Rettigheder til agentens login (se db/permissions/grant-least-privilege.sql; [agent] = agentens login):
|
|
-- GRANT VIEW SERVER STATE TO [agent]; -- SQL Server 2005-2019
|
|
-- GRANT VIEW SERVER PERFORMANCE STATE TO [agent]; -- SQL Server 2022+ (erstatter VIEW SERVER STATE)
|
|
-- GRANT VIEW SERVER SECURITY STATE TO [agent]; -- SQL Server 2022+
|
|
-- USE msdb; GRANT SELECT ON dbo.sysjobs TO [agent]; GRANT SELECT ON dbo.sysjobhistory TO [agent];
|
|
--
|
|
-- Data kommer fra (collector, fil : medlemmer, interval):
|
|
-- AgentJobCollector
|
|
-- Fil: src/SQLInsight.Collectors/Instance/AgentJobCollector.cs
|
|
-- Medlemmer: AgentJobCollector.RunningSql, AgentJobCollector.JobsSql
|
|
-- Interval: 5 min som standard (SQLInsight:CollectorIntervals:agent-jobs)
|
|
-- Delt script: SQL Scripts/_collectors/AgentJobCollector.sql
|
|
-- InstanceProbe
|
|
-- Fil: src/SQLInsight.Connectivity/InstanceProbe.cs
|
|
-- Medlemmer: InstanceProbe.Query
|
|
-- Interval: én gang, når agenten forbinder til instansen
|
|
-- Delt script: SQL Scripts/_collectors/InstanceProbe.sql
|
|
-- Regelkode: src/SQLInsight.Rules/Availability/AvailabilityRules.cs : AgentStoppedRule.Evaluate
|
|
--
|
|
-- Read-only: Ja: kun SELECT samt lokale variabler, SET-sessionsindstillinger. Intet ændrer data, indstillinger
|
|
-- eller objekter.
|
|
-- Kørsel: Kør i SSMS som agentens login (eller et login med samme rettigheder). Hver variant er sin egen batch
|
|
-- (GO); en variant for en anden SQL Server-version end din kan fejle - det er forventet.
|
|
-- Per-database-forespørgsler er vist for databasen msdb, som findes overalt: ret navnet til den
|
|
-- database, du vil se.
|
|
-- ===================================================================================================================
|
|
|
|
-- -------------------------------------------------------------------------------------------------------------------
|
|
-- Forbindelsen: Sessionsindstillinger, agenten sætter på hver forbindelse
|
|
-- -------------------------------------------------------------------------------------------------------------------
|
|
|
|
-- Variant: Alle versioner: sættes på hver forbindelse, agenten åbner
|
|
-- Kilde: SqlConnectionFactory.SessionSettings
|
|
-- Kode: src/SQLInsight.Connectivity/SqlConnectionFactory.cs : SqlConnectionFactory.SessionSettings
|
|
SET LOCK_TIMEOUT 5000; SET DEADLOCK_PRIORITY LOW; SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
|
|
GO
|
|
|
|
-- -------------------------------------------------------------------------------------------------------------------
|
|
-- AgentJobCollector: SQL Agent-jobs fra msdb: aktiv, seneste udfald, seneste fejlende trin og antal fejl det seneste
|
|
-- døgn, og om SQL Server Agent kører.
|
|
-- -------------------------------------------------------------------------------------------------------------------
|
|
|
|
-- Variant: SQL Server 2005 og nyere
|
|
-- Kilde: AgentJobCollector.RunningSql
|
|
-- Kode: src/SQLInsight.Collectors/Instance/AgentJobCollector.cs : AgentJobCollector.RunningSql
|
|
SELECT COUNT(*) FROM sys.dm_exec_sessions WHERE program_name LIKE N'SQLAgent - %'
|
|
GO
|
|
|
|
-- Variant: SQL Server 2005 og nyere
|
|
-- Kilde: AgentJobCollector.JobsSql
|
|
-- Kode: src/SQLInsight.Collectors/Instance/AgentJobCollector.cs : AgentJobCollector.JobsSql
|
|
DECLARE @since int;
|
|
SET @since = CONVERT(int, CONVERT(char(8), DATEADD(day, -1, GETDATE()), 112));
|
|
SELECT j.name, j.enabled, last_run.run_status, last_run.run_date, last_run.run_time,
|
|
failed_step.step_name, LEFT(failed_step.message, 2000), failures.n
|
|
FROM msdb.dbo.sysjobs j
|
|
OUTER APPLY (SELECT TOP (1) h.run_status, h.run_date, h.run_time FROM msdb.dbo.sysjobhistory h
|
|
WHERE h.job_id = j.job_id AND h.step_id = 0 ORDER BY h.instance_id DESC) last_run
|
|
OUTER APPLY (SELECT TOP (1) h.step_name, h.message FROM msdb.dbo.sysjobhistory h
|
|
WHERE h.job_id = j.job_id AND h.step_id > 0 AND h.run_status = 0 ORDER BY h.instance_id DESC) failed_step
|
|
OUTER APPLY (SELECT COUNT(*) AS n FROM msdb.dbo.sysjobhistory h
|
|
WHERE h.job_id = j.job_id AND h.step_id = 0 AND h.run_status = 0 AND h.run_date >= @since) failures
|
|
GO
|
|
|
|
-- -------------------------------------------------------------------------------------------------------------------
|
|
-- InstanceProbe: Registrering af instansen: version, udgave, cluster og Always On. Køres, når agenten forbinder, og
|
|
-- bestemmer hvilke varianter og regler der bruges.
|
|
-- -------------------------------------------------------------------------------------------------------------------
|
|
|
|
-- Variant: Alle versioner (SQL Server 2000 og nyere)
|
|
-- Kilde: InstanceProbe.Query
|
|
-- Kode: src/SQLInsight.Connectivity/InstanceProbe.cs : InstanceProbe.Query
|
|
SELECT
|
|
CAST(SERVERPROPERTY('ServerName') AS nvarchar(256)),
|
|
CAST(SERVERPROPERTY('ProductVersion') AS nvarchar(128)),
|
|
CAST(SERVERPROPERTY('ProductLevel') AS nvarchar(128)),
|
|
CAST(SERVERPROPERTY('ProductUpdateLevel') AS nvarchar(128)),
|
|
CAST(SERVERPROPERTY('Edition') AS nvarchar(128)),
|
|
CAST(SERVERPROPERTY('EngineEdition') AS int),
|
|
CAST(SERVERPROPERTY('IsClustered') AS int),
|
|
CAST(SERVERPROPERTY('IsHadrEnabled') AS int)
|
|
GO
|