Søren Eggert Lundsteen Olsen
2284e7f082
A DBA should be able to review every statement SQLInsight sends to a monitored server before granting it access. "SQL Scripts/<rule-id>.sql" holds, per rule (82 built-in, 16 community), a Danish header (what and why, how C# judges the data, thresholds with config keys, severity, exact GRANTs, versions, collector file and member) and the collector's SQL verbatim, every version variant as its own batch. "_collectors/<Collector>.sql" holds each collector's queries once. The only statement that is not strictly read-only is documented in the scripts: the deadlock collector's session temp table (#system_health). Inline SQL in the collectors moved to internal constants and Build*Sql methods (no text changed), so SqlScriptTests can check that the scripts still contain the SQL the code sends, that every rule has a script, that every collector query is registered, and that nothing writes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
87 lines
4.9 KiB
Transact-SQL
87 lines
4.9 KiB
Transact-SQL
-- ===================================================================================================================
|
|
-- SQLI-WAIT-003: Sessioner venter meget på låse
|
|
-- ===================================================================================================================
|
|
-- Regel-id: SQLI-WAIT-003
|
|
-- Titel: Sessioner venter meget på låse
|
|
-- Alvor: Medium; High fra 5 ventende tasks i gennemsnit.
|
|
-- Versioner: Alle.
|
|
--
|
|
-- Hvad tjekkes, og hvorfor:
|
|
-- Om sessioner venter meget på låse (LCK_M_*), dvs. blocking.
|
|
--
|
|
-- Vurdering (sker i C# ud fra de indsamlede data, ikke i SQL'en, medmindre andet er nævnt):
|
|
-- Forskellen mellem to målinger, uden godartede ventetyper. Fund hvis LCK_M_* udgør mindst 20 % af al ventetid og i
|
|
-- gennemsnit mindst 0,5 task venter på låse (ventetid / intervallets længde).
|
|
--
|
|
-- Grænseværdier (konfigurationsnøgle i agentens appsettings.json og standardværdi):
|
|
-- Andel >= 20 %, gns. ventende >= 0,5; High fra 5 (fast i koden).
|
|
--
|
|
-- Rettigheder til agentens login (se db/permissions/grant-least-privilege.sql; [agent] = agentens login):
|
|
-- GRANT VIEW SERVER STATE TO [agent]; -- SQL Server 2005-2019
|
|
-- GRANT VIEW SERVER PERFORMANCE STATE TO [agent]; -- SQL Server 2022+ (erstatter VIEW SERVER STATE)
|
|
-- GRANT VIEW SERVER SECURITY STATE TO [agent]; -- SQL Server 2022+
|
|
-- SQL Server 2000 har ikke VIEW SERVER STATE; se docs/legacy-versions.md (fx kræver DBCC SQLPERF(WAITSTATS) forhøjede rettigheder).
|
|
--
|
|
-- Data kommer fra (collector, fil : medlemmer, interval):
|
|
-- WaitStatsCollector
|
|
-- Fil: src/SQLInsight.Collectors/Performance/WaitStatsCollector.cs
|
|
-- Medlemmer: Db.StartTimeSql(version), WaitStatsCollector.Sql2005, WaitStatsCollector.Sql2000
|
|
-- Interval: 5 min som standard (SQLInsight:CollectorIntervals:wait-stats)
|
|
-- Delt script: SQL Scripts/_collectors/WaitStatsCollector.sql
|
|
-- Regelkode: src/SQLInsight.Rules/Performance/WaitRules.cs : WaitRules.Create (DominantWaitRule "SQLI-WAIT-003",
|
|
-- kategori Locks)
|
|
--
|
|
-- Read-only: Ja: kun SELECT samt DBCC SQLPERF(WAITSTATS) (læser ventetider, SQL Server 2000),
|
|
-- SET-sessionsindstillinger. Intet ændrer data, indstillinger eller objekter.
|
|
-- Kørsel: Kør i SSMS som agentens login (eller et login med samme rettigheder). Hver variant er sin egen batch
|
|
-- (GO); en variant for en anden SQL Server-version end din kan fejle - det er forventet.
|
|
-- Per-database-forespørgsler er vist for databasen msdb, som findes overalt: ret navnet til den
|
|
-- database, du vil se.
|
|
-- ===================================================================================================================
|
|
|
|
-- -------------------------------------------------------------------------------------------------------------------
|
|
-- Forbindelsen: Sessionsindstillinger, agenten sætter på hver forbindelse
|
|
-- -------------------------------------------------------------------------------------------------------------------
|
|
|
|
-- Variant: Alle versioner: sættes på hver forbindelse, agenten åbner
|
|
-- Kilde: SqlConnectionFactory.SessionSettings
|
|
-- Kode: src/SQLInsight.Connectivity/SqlConnectionFactory.cs : SqlConnectionFactory.SessionSettings
|
|
SET LOCK_TIMEOUT 5000; SET DEADLOCK_PRIORITY LOW; SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
|
|
GO
|
|
|
|
-- -------------------------------------------------------------------------------------------------------------------
|
|
-- WaitStatsCollector: Kumulative ventetider. Reglerne bruger forskellen mellem to målinger; en genstart (nyt
|
|
-- starttidspunkt) nulstiller.
|
|
-- -------------------------------------------------------------------------------------------------------------------
|
|
|
|
-- Variant: SQL Server 2008 og nyere: starttidspunkt (nulstilling af kumulative tal)
|
|
-- Kilde: WaitStatsCollector.StartTimeSql(2008+)
|
|
-- Kode: src/SQLInsight.Collectors/Db.cs : Db.StartTimeSql(version)
|
|
SELECT (SELECT sqlserver_start_time FROM sys.dm_os_sys_info)
|
|
GO
|
|
|
|
-- Variant: SQL Server 2005: starttidspunkt
|
|
-- Kilde: WaitStatsCollector.StartTimeSql(2005)
|
|
-- Kode: src/SQLInsight.Collectors/Db.cs : Db.StartTimeSql(version)
|
|
SELECT (SELECT create_date FROM sys.databases WHERE database_id = 2)
|
|
GO
|
|
|
|
-- Variant: SQL Server 2000 (legacy ODBC-sti): starttidspunkt
|
|
-- Kilde: WaitStatsCollector.StartTimeSql(2000)
|
|
-- Kode: src/SQLInsight.Collectors/Db.cs : Db.StartTimeSql(version)
|
|
SELECT (SELECT login_time FROM master.dbo.sysprocesses WHERE spid = 1)
|
|
GO
|
|
|
|
-- Variant: SQL Server 2005 og nyere
|
|
-- Kilde: WaitStatsCollector.Sql2005
|
|
-- Kode: src/SQLInsight.Collectors/Performance/WaitStatsCollector.cs : WaitStatsCollector.Sql2005
|
|
SELECT wait_type, waiting_tasks_count, wait_time_ms, signal_wait_time_ms
|
|
FROM sys.dm_os_wait_stats
|
|
WHERE wait_time_ms > 0
|
|
GO
|
|
|
|
-- Variant: SQL Server 2000 (legacy ODBC-sti)
|
|
-- Kilde: WaitStatsCollector.Sql2000
|
|
-- Kode: src/SQLInsight.Collectors/Performance/WaitStatsCollector.cs : WaitStatsCollector.Sql2000
|
|
DBCC SQLPERF(WAITSTATS) WITH NO_INFOMSGS
|
|
GO
|